Repository navigation
Consolidate dependabot dependency updates - #307
Merged
Merged
Conversation
Applies the open dependabot updates in one change: - room-manager: axios ^1.15.0, fastify ^5.7.3, @fastify/cors ^11.1.0, fluent-json-schema ^6.0.0 - lockfile: source-map-js, vite, picomatch, flatted, elysia, minimatch, rollup, jws, form-data - dev tooling: eslint 10, @eslint/js 10, globals 17, typescript-eslint, prettier, cspell, lint-staged, typedoc, typedoc-material-theme, tsup, ts-proto, openapi-generator-cli, @fastify/swagger, pino-pretty, tsx, bun-types, typescript 5.9 Follow-ups required by the bumps: - room-manager: pass ignoreTrailingSlash via routerOptions (top-level option is deprecated in newer fastify 5.x) - composition: drop eslint-disable for no-var, unused under eslint 10 - js-server-sdk: set tsup removeNodeProtocol: false so the published bundle keeps node: builtin specifiers (tsup 8.5 strips them by default) TypeScript 6 and @types/node 25 are not included.
Magmusacy
approved these changes
Oct 22, 2026
- multimodal, transcription, selective-subscription backend: declare @sinclair/typebox. elysia 1.4 no longer installs it, so the examples failed at startup with "Cannot find module '@sinclair/typebox'". - selective-subscription backend: return the SSE stream as a plain Response. elysia 1.4 appended "text/plain" to the Content-Type set via set.headers, which made the frontend's EventSource reject the stream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What's bumped
Example runtime deps (room-manager)
^1.7.9→^1.15.0(Bump axios from 1.7.9 to 1.15.0 #258, Bump axios from 1.7.9 to 1.13.0 #211)^5.2.1→^5.7.3(Bump fastify from 5.2.1 to 5.7.3 #227, Bump fastify from 5.2.1 to 5.6.1 #201)^10.1.0→^11.1.0(Bump @fastify/cors from 10.1.0 to 11.1.0 #181)^5.0.0→^6.0.0(Bump fluent-json-schema from 5.0.0 to 6.0.0 #143)Lockfile-only (transitive)
Dev tooling (#237)
^5.9.3Not included from #237
moduleResolution: "node"is deprecated and now a hard error (TS5107) infishjam-openapi,fishjam-protoandcomposition-openapi. This needs a tsconfig migration, which belongs in a separate PR.^22.Code changes the bumps required
examples/room-manager/src/index.ts: passignoreTrailingSlashviarouterOptions. The top-level option raisesFSTDEP022on newer fastify 5.x.packages/composition/src/eventBus.ts: removed aneslint-disable no-varthat eslint 10 reports as unused.packages/js-server-sdk/package.json: set tsupremoveNodeProtocol: false. tsup 8.5 stripsnode:from ESM imports too (8.4 only did it for CJS). With this option the ESM bundle keepsnode:crypto/node:fs/promisesas before, and CJS now uses them as well (fine on Node >= 18).examples/{multimodal,transcription,selective-subscription/backend}: declare@sinclair/typebox. elysia 1.4 no longer installs it, so these examples crashed at startup withCannot find module '@sinclair/typebox'.examples/selective-subscription/backend/src/controllers/notifications.ts: return the SSE stream as a plainResponse. elysia 1.4 appendedtext/plainto theContent-Typeset throughset.headers, which made the frontend'sEventSourcereject the stream.Verification
Compared against a clean build of
main:yarn install --immutable,format:check,build,lint:check,docs,spellcheck: passtscrun directly in all 12 workspaces: 0 errorsclient.test.tsexcluded locally; runs in CI)selective-subscription-frontendandroom-managerbuilds pass/health, CORS, preflight, query validation (400 on missingpeerName), trailing-slash routing and 404 all matchmain; no deprecation warningsyarn packfile lists matchmainfor js-server-sdk, composition and composition-cli. Type declarations differ only in import order. JS differences in js-server-sdk:@bufbuild/protobuf2.x (pulled in by ts-proto)AgentRequest/AgentResponse/ServerMessagecode against@bufbuild/protobuf2.0.0 (main) and 2.16.0 (this branch). All 307 checks pass: encoded bytes are identical, each version decodes the other's output (audio frames 0 B–1 MB, images up to 2 MB, all 33 server notification types), unknown fields are skipped the same way, invalid UTF-8 is handled the same way, andfinish()returns an exact-size copy. Audio frame encoding is ~30% faster.main. The SSEContent-Typeis now a singletext/event-stream(mainsent the value twice).yarn npm audit --all --recursive: advisory count 213 → 83Motivation and Context
Consolidates the open dependabot PRs into a single update on top of current
main. All of them conflict withmainonyarn.lock, so the bumps were re-applied fresh withyarn upinstead of merging the branches.Supersedes #306, #258, #255, #251, #249, #241, #237, #236, #235, #227, #215, #211, #201, #181, #172, #143. Dependabot should close them automatically once this lands.
Documentation impact
Types of changes
not work as expected)