Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sharp turns with openpilot longitudinal configured on the Kia EV9 can end in “Steering Assist Temporarily Unavailable” and a steering dropout. Assistance can briefly return and drop out again, including when longitudinal is disengaged and only lateral assistance is active. This was reproduced on stock stable StarPilot; I have not observed it with stock ACC. Dom still permits autonomous angle targets well beyond the roughly 140° assisted-wheel plateau seen in the logs.
This change caps the EV9 autonomous target at ±140° before filtering on the OP-long steering path. Saturating the target does not itself deactivate steering. Stock ACC, other vehicles, inactive measured-angle commands, existing rate limits and Panda safety limits retain their current behavior. This is a target limit, not a hard clamp on the physical wheel or every transmitted angle during reentry.
Verification
The reproduction used stock StarPilot stable at
c3e4ec630f41c4baa43254a90f718abd1bf764a1, installed through an exact-tree mirror at272b7edcb30238297efe934f71b826dd2d810d1d(the commit recorded in the logs), with stock bundled Panda firmware and no custom changes.Reproduction route — full logs uploaded. Useful windows from route start: 4:25–4:29 for repeated left-turn faults, and 4:51–4:58 for another cluster and the displayed warning.
LKA_ANGLE_FAULTwhile ordinaryLKA_FAULTremains clear. Near 4:25.48, speed is 19.7 km/h and the measured wheel angle is 137.6° left. The preceding logged CAN batch requests 206.7° left; the batch containing the first fault includes a 208.1° left request. No driver steering override is detected at that first onset.