Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Always On Lateral can steer while normal engagement is inactive. In Dom, steering-limit feedback only updates during normal engagement, so it can miss new limits or retain an old result. We now update it whenever lateral control is active and clear it when lateral control stops. This keeps steering-limit detection and controller integrator handling supplied with current feedback during lateral-only driving.
We needed this in our EV9 branch because we use steering without cruise engaged, and our steering-limit warnings depend on that feedback. The fix applies across vehicles and preserves existing steering limits and tuning.
The test-file addition reuses the existing publish harness to check angle and torque feedback during lateral-only driving and stop/restart transitions. The previous tests keep normal engagement and lateral control active together, so they do not cover this issue.
Verification
git diff --checkpassed.