Skip to content

Fix App Distribution crash when no screenshot is available - #16674

Open
Hokila wants to merge 2 commits into
firebase:mainfrom
Hokila:fix-app-distribution-empty-screenshot
Open

Hokila wants to merge 2 commits into
firebase:mainfrom
Hokila:fix-app-distribution-empty-screenshot

Conversation

@Hokila

@Hokila Hokila commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

getManuallyCapturedScreenshot indexed the first PHAsset without checking whether PhotoKit returned any screenshot assets. An empty screenshot result could raise NSRangeException and crash App Distribution in-app feedback.

Changes

  • Return nil when no screenshot asset is available.
  • Add a regression test for the empty fetch-result path.
  • Document the fix in the App Distribution changelog.

Validation

  • AppDistributionUnit: 48 tests passed.

Return no screenshot when PhotoKit has no matching assets instead of indexing an empty fetch result. Add a regression test covering the empty-result path.
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Exercise screenshot retrieval with an injected empty PhotoKit result so the regression test verifies that completion receives nil.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant