Skip to content

Adds safety checks for getting lib path in symbol resolver - #16671

Open
mghaznav wants to merge 1 commit into
mainfrom
ali/fix-frame-library-path-resolver
Open

mghaznav wants to merge 1 commit into
mainfrom
ali/fix-frame-library-path-resolver

Conversation

@mghaznav

Copy link
Copy Markdown
Contributor

Fixes #16106

Description

Fixes an issue where a null, missing, or empty path in a binary image record could cause crashes (unrecognized selector on NSNull) or leave FIRStackFrame.library unpopulated.

Changes

  • Safe Type Checking: Validates that binaryImage[@"path"] is a non-empty NSString before calling lastPathComponent.
  • dladdr Fallback: Falls back to [NSString stringWithUTF8String:dlInfo.dli_fname].lastPathComponent if the recorded path is null, missing, or empty.
  • Nullability Handling: Leaves frame.library as nil if no valid name is resolvable.

Verification

  • Verified that valid paths resolve correctly.
  • Verified that null, @"", and missing paths fall back to dladdr or remain safely nil without crashing.
  • Tested on simulators and a real device

@mghaznav
mghaznav requested review from mrober and ncooke3 September 18, 2026 18:51
@mghaznav mghaznav self-assigned this Sep 18, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@mghaznav

Copy link
Copy Markdown
Contributor Author

Failing test FIRCLSReportUploaderTests testUrgentWaitUntilUpload is unrelated to this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crashlytics no longer reporting non-fatal call line

2 participants