Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request promotes the Server Prompt Template APIs to General Availability (GA) by removing the 'Public Preview' warnings from the documentation of TemplateChatSession and TemplateGenerativeModel, and updating the CHANGELOG. However, the TemplateChatSession class and its methods remain internal; they should be updated to public to allow external developers to use these GA features.
I am having trouble creating individual review comments. Click here to see my feedback.
FirebaseAI/Sources/TemplateChatSession.swift (20-21)
Since the Server Prompt Template APIs are being promoted to GA, the TemplateChatSession class and its methods (as well as the startChat method in TemplateGenerativeModel) should be made public as indicated by the TODO comments. Currently, they remain internal, which prevents external developers from using the chat session features of the prompt templates. Since the 'Public Preview' warnings are being removed here, please restore the public access modifier to these APIs.
|
We don't want to include iOS Server Prompt Template Chat APIs in the GA. |
|
/gemini summarize |
@paulb777 It's likely confused due to the PR description:
|
There was a problem hiding this comment.
We should revert this file since these APIs are still internal.
There was a problem hiding this comment.
They're not public preview.
This pull request promotes the Server Prompt Template APIs to General Availability (GA) by removing the 'Public Preview' warnings from the documentation of TemplateChatSession and TemplateGenerativeModel, and updating the CHANGELOG.