Skip to content

[AI] Server Prompt Template GA - #16667

Open
paulb777 wants to merge 1 commit into
mainfrom
pb-spt-ga
Open

paulb777 wants to merge 1 commit into
mainfrom
pb-spt-ga

Conversation

@paulb777

@paulb777 paulb777 commented Sep 17, 2026

Copy link
Copy Markdown
Member

This pull request promotes the Server Prompt Template APIs to General Availability (GA) by removing the 'Public Preview' warnings from the documentation of TemplateChatSession and TemplateGenerativeModel, and updating the CHANGELOG.

@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@paulb777

Copy link
Copy Markdown
Member Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request promotes the Server Prompt Template APIs to General Availability (GA) by removing the 'Public Preview' warnings from the documentation of TemplateChatSession and TemplateGenerativeModel, and updating the CHANGELOG. However, the TemplateChatSession class and its methods remain internal; they should be updated to public to allow external developers to use these GA features.

I am having trouble creating individual review comments. Click here to see my feedback.

FirebaseAI/Sources/TemplateChatSession.swift (20-21)

high

Since the Server Prompt Template APIs are being promoted to GA, the TemplateChatSession class and its methods (as well as the startChat method in TemplateGenerativeModel) should be made public as indicated by the TODO comments. Currently, they remain internal, which prevents external developers from using the chat session features of the prompt templates. Since the 'Public Preview' warnings are being removed here, please restore the public access modifier to these APIs.

@paulb777

Copy link
Copy Markdown
Member Author

We don't want to include iOS Server Prompt Template Chat APIs in the GA.

@paulb777

Copy link
Copy Markdown
Member Author

/gemini summarize

@firebase firebase deleted a comment from gemini-code-assist Bot Sep 17, 2026
@andrewheard

Copy link
Copy Markdown
Contributor

We don't want to include iOS Server Prompt Template Chat APIs in the GA.

@paulb777 It's likely confused due to the PR description:

This pull request promotes the Server Prompt Template APIs to General Availability (GA) by removing the 'Public Preview' warnings from the documentation of TemplateChatSession and TemplateGenerativeModel, and updating the CHANGELOG.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should revert this file since these APIs are still internal.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're not public preview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants