Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
|
Please fix the unit test build issue: |
|
Fixed in the latest commit and verified with CocoaPods lint on Xcode 26.4. Thanks! |
Motivation
AuthAPNSTokenManagerstarts one timeout for the first caller and coalesces later callers into the same pending batch. The timeout previously compared callback counts, so adding a second waiter changed the count and prevented the timeout from firing. The corresponding asyncgetToken()continuations could then wait indefinitely.Related: #13470
Changes
Non-goals
error!sites or Storage/Database TODOs.Validation
xcodebuild -scheme AuthUnit -destination 'platform=iOS Simulator,id=B33A771B-CD3A-41BA-81ED-2CFEE30AEA14' -only-testing:AuthUnit/AuthAPNSTokenManagerTests CODE_SIGNING_ALLOWED=NO test— 8 tests passed.xcodebuild -scheme AuthUnit -destination 'platform=iOS Simulator,id=B33A771B-CD3A-41BA-81ED-2CFEE30AEA14' CODE_SIGNING_ALLOWED=NO test— 354 tests passed../scripts/check.sh --allow-dirty --test-only upstream/main— passed.git diff --check— passed.API / release impact
Internal correctness fix only; no public API or compatibility changes.