Skip to content

[Firestore] Migrate deprecated Abseil types and attributes to C++17 standard library - #16656

Open
cherylEnkidu wants to merge 20 commits into
cheryl/improveTestingfrom
cheryl/cppfeature
Open

cherylEnkidu wants to merge 20 commits into
cheryl/improveTestingfrom
cheryl/cppfeature

Conversation

@cherylEnkidu

@cherylEnkidu cherylEnkidu commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Description

Following the migration to C++17 as the minimum language standard (#15074), this PR modernizes Firestore Core by migrating deprecated Abseil attributes and types to their standard C++17 equivalents:

  1. [[maybe_unused]] Attribute:

    • Replaced deprecated ABSL_ATTRIBUTE_UNUSED with C++17 [[maybe_unused]] in iterator_adaptors_test.cc.
  2. std::void_t Migration:

    • Replaced absl::void_t with std::void_t in Firestore core utility headers (iterator_adaptors.h, type_traits.h, to_string.h, and comparison.h).
    • Removed obsolete #include "absl/meta/type_traits.h" headers.
  3. std::optional Migration:

    • Replaced absl::optional, absl::nullopt, and absl::make_optional with standard std::optional, std::nullopt, and std::make_optional across 29 Firestore core source files in api/, bundle/, core/, local/, model/, and remote/.
    • Included <optional> where needed and removed unneeded Abseil type includes.

Testing

  • Verified Swift package manifest syntax (swift package dump-package).
  • Verified header compilation and syntax with Clang C++17 (-std=c++17).

API Changes

None. These are internal implementation cleanups only.

#no-changelog

@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@cherylEnkidu
cherylEnkidu changed the base branch from main to cheryl/improveTesting September 16, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant