[Firestore] Migrate deprecated Abseil types and attributes to C++17 standard library - #16656
cherylEnkidu wants to merge 20 commits into
Conversation
Remove the intentional failure
…CXX_LANGUAGE_STANDARD = c++17 specifically for abseil targets in Podfile and suppress deprecated warnings for integration tests in sync_project.rb
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
Description
Following the migration to C++17 as the minimum language standard (#15074), this PR modernizes Firestore Core by migrating deprecated Abseil attributes and types to their standard C++17 equivalents:
[[maybe_unused]]Attribute:ABSL_ATTRIBUTE_UNUSEDwith C++17[[maybe_unused]]initerator_adaptors_test.cc.std::void_tMigration:absl::void_twithstd::void_tin Firestore core utility headers (iterator_adaptors.h,type_traits.h,to_string.h, andcomparison.h).#include "absl/meta/type_traits.h"headers.std::optionalMigration:absl::optional,absl::nullopt, andabsl::make_optionalwith standardstd::optional,std::nullopt, andstd::make_optionalacross 29 Firestore core source files inapi/,bundle/,core/,local/,model/, andremote/.<optional>where needed and removed unneeded Abseil type includes.Testing
swift package dump-package).-std=c++17).API Changes
None. These are internal implementation cleanups only.
#no-changelog