Repository navigation
Conversation
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3504
When the URL hash is edited by hand, React Router has no history state for the new location and gives it the key "default", the same key as a first page load. useResourceNavigationKey only compared location.key, so it did not see a navigation and Hub kept the previously loaded resource on screen.
For locations with the key "default", the hook now also uses the pathname to tell navigations apart. A query-only change under that key still keeps the resource, as before.
Testing: added two regression tests for locations without history state (a path change changes the key, a query-only change keeps it). The path change test fails without the fix. The existing tests in src/hub/hooks still pass and eslint is clean. I did not run the full hub with a backend locally, so I have not checked the exact steps from the issue in a browser.