Repository navigation
fix(calm-hub): declare CALM 1.3 in the seed patterns - #3513
Merged
rocketstack-matt merged 5 commits intoOct 27, 2026
Merged
rocketstack-matt merged 5 commits into
rocketstack-matt merged 5 commits into
Conversation
The API Gateway, Conference Signup, Conference Secure Signup and Demo patterns referred to https://calm.finos.org/calm/schemas/2025-03/meta/, which never resolved. Each named 2025-03 interface is now interface-type with the same fields, and the secure signup pattern uses the 1.0 control keys. Refs finos#3240.
rocketstack-matt
requested review from
a team,
Thels,
grahampacker-ms,
jpgough-ms,
markscott-ms and
willosborne
as code owners
October 26, 2026 21:33
markscott-ms
previously approved these changes
Oct 26, 2026
markscott-ms
left a comment
Contributor
There was a problem hiding this comment.
Approved. One side effect to fix here or in a new issue:
extractInterfaces in calm-hub-ui/src/visualizer/components/reactflow/utils/patternTransformer.ts takes the interface type from the last segment of the $ref. All the seeded refs now end in interface-type, so the visualizer shows every interface as interface-type, not url-interface, host-port-interface and so on. patternTransformer.test.ts tests only the old form, so no test catches this.
Member
Author
|
@markscott-ms Confirmed, fixed in 805c809. |
markscott-ms
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Step 6 of #3240. The CALM Hub seed patterns and one Cypress fixture declared
https://calm.finos.org/calm/schemas/2025-03/meta/.... That is the 2025-03 draft on a CALM Hub path, and it never resolved on calm.finos.org. Both seeds now declare CALM 1.3. That covers the Mongo seed (API Gateway, Conference Signup and Conference Secure Signup patterns) and the Nitrite seed, which builds hub.calm.finos.org (the same three, Conference Signup 2.0.0, and the three Demo Pattern versions).The migration is the same as in #3468 for the shared fixture copies of these patterns:
interface.json#/defs/url-interface,host-port-interface,port-interface,container-image-interfaceinterface.json#/defs/interface-type, with the fields andrequiredlist of the old definition (url;host,port;port;image)calm/schemas/2025-03/meta/refrelease/1.3/meta/control-requirement-url,control-config-urlrequirement-url,config-url(the 1.0 names)Gotchas:
load-balancer-attendees-service, and the Mongo copy names itload-balancer-attendees. This PR does not change that difference.shareddocument-loader tests still use the old URL as a mocked request. Nothing fetches it.$refdefinition. A 1.3 interface refers to the genericinterface-type, so the visualizer no longer showsinterface-typeorinterface-definitionas a type.Type of Change
Affected Components
cli/)calm/)calm-ai/)calm-hub/)calm-hub-ui/)calm-lab/)calm-models/)calm-server/)calm-studio/)calm-widgets/)calm-guard/)docs/)shared/)calm-plugins/vscode/)Commit Message Format ✅
One commit for each package, and one for the visualizer fix. None releases the CLI.
Testing
I have tested my changes locally
I have added/updated unit tests
All existing tests pass
ajv with the 1.3 meta-schemas from
@finos/calm-schema: all 11 changed patterns are valid againstcalm.jsonand compile, so every$refresolves.The 1.3 conference signup architecture in
shared/test_fixturesis valid against each changed Conference Signup pattern, and the 1.3 secure signup architecture is valid against the Mongo Conference Secure Signup pattern. Against the Nitrite copy it is valid once its second relationship has that pattern's ID.init-mongo.jsin amongo:latestcontainer: the seed completes, and no seeded document refers to the old path.scripts/validate-mongo-seed-counters.jspasses.init-nitrite.shagainst a standalone CALM Hub: the seed completes with no errors. A GET of every readable resource returns 278 responses, all 200, and none refers tocalm.finos.org/calm/schemas/orcalm.finos.org/draft/.Checklist
🤖 Generated with Claude Code