Repository navigation
fix: sweep 5 - #87
Merged
Merged
fix: sweep 5#87
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five audits (ES5 build, router and form parser, events, Matreshka.Array, docs and skill); every fix has a spec that fails on
fec0a1c(test/spec/regressions/sweep5_*_spec.js,docs/test/code-parity.test.js).Events
click::x) follow listener owners: a second path or the object's ownonkeeps themoff('click::x')no longer leaves_unbind:xentries behindoffcancels a pending DOMonDebouncecalloncefires once when an earlier handler triggers the same event againRouter
#Router.hashandRouter.historywork on first use, without a subscriberRoutermethods aren't enumerable indist/ES5 build
<col>renders without<template>{{x}}showString(value)indist/as insrc/Array.fromfallback keeps holes (Matreshka.Array.from({length: 3}, fn))__proto__data key no longer sets the prototype (fromEntries)Classchain over an ES class works insrc/and.min.mjs, as indist/assignandforOwnfallbacks take primitivesMatreshka.Array
splicethat adds items works after the container is reboundrestore()with aMatreshka.ArrayModel gives empty collectionspushof a rendered item,fill,copyWithin) leaves the array unchangedflatandflatMapspread nestedMatreshka.Arrayinstances, asconcatdoesDocs and skill
'change: a'with a space in ua)matreshka.min.mjsis a little smaller than the script-tag fileAlso: the legacy scenario waits through timers, so it doesn't flake on a busy machine.
Not changed: a route without
*('/x/') still drops deeper URL parts on write; the documented pattern for classes sharing a URL pads with*.Gates: lint, typecheck, 1050 tests with 100% coverage, build, check:dist (1002 tests on dist, 16 legacy cases), build:docs. Checked in Chrome on the built bundle against the 3.0.1 bundle.