INTER-2348: Close coverage gaps and drop dead wait-until helper by JuroUhlar · Pull Request #208 · fingerprintjs/react

JuroUhlar · 2026-07-21T11:38:49Z

Add targeted coverage for provider initialization, rebuild behavior, SSR handling, hook race and error paths, and environment detection
Verify public hook behavior for default fetching, settled-request eviction, refetch state, and semantic option changes
Remove hollow and low-value tests
Delete the unused wait-until helper left over from the v4 agent migration
Keep the provider public API and runtime behavior unchanged

Verification

42 tests passing
96.4% statement, 94.79% branch, and 96.89% line coverage
Lint and production build passing

Widen the react peer range to >=18 <20, verify the SDK against React 19 via a second CI matrix job (catalog stays pinned to 18 as the default dev/test toolchain), and bump the Next.js examples to 16.2.10. Add @next/eslint-plugin-next lint rules scoped to the Next examples instead of eslint-config-next, since the latter bundles eslint-plugin-react which only supports ESLint below version 10. Re-add the two @eslint-react rule overrides for React 19-only idioms so linting stays green under both supported versions.

Next.js 16 requires Node >=20.9.0; declare it explicitly so contributors on older Node get a clear engine error instead of a confusing runtime failure.

no-html-link-for-pages (and other core-web-vitals rules) default to looking for pages/app at the repo root, so they silently no-op since both Next examples live under examples/. Set settings.next.rootDir to point at them explicitly.

Add a CI matrix that boots each example app with Playwright and asserts the Fingerprint React SDK identifies the visitor (a visitor ID renders in the browser). Each example is tested against the React versions it supports. - e2e/: a single Playwright harness driven by an EXAMPLE env var, with a per-example registry (examples.ts) and one framework-agnostic spec. - .github/workflows/e2e.yml: matrix of {example} x {React 18, 19}. React 19 jobs flip the pnpm catalog so the SDK and every example move in lockstep (a single @types/react, which the Next App Router type-check requires). The preact example runs once (it uses Preact via preact/compat). - examples: optional region env support (the CI key is EU) that leaves the default behavior unchanged. Also fixes pre-existing build breakage: the CRA example was missing react-app-env.d.ts, and the preact example's ESM preact.config.js failed to load on Node 22 (and was redundant with preact-cli's native .env / PREACT_APP_* injection) so it was removed and a scoped process type declaration added. INTER-2322 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014F14pjZxadmtLq8uTuzwXb

Read the Fingerprint region from the FPJS_REGION Actions variable (defaulting to eu) instead of hardcoding it, so the region is configurable alongside the public key secret. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014F14pjZxadmtLq8uTuzwXb

Drop the eu fallback so the region comes solely from the FPJS_REGION repo variable, and fail fast in the pre-flight check when it (or the API key secret) is missing. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014F14pjZxadmtLq8uTuzwXb

The Fingerprint public key isn't sensitive, so read FPJS_PUBLIC_API_KEY from either a repo secret or a repo variable. Fixes the matrix failing when the key was added under the Variables tab alongside FPJS_REGION. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014F14pjZxadmtLq8uTuzwXb

preact-cli's dev server (`preact watch`) fails to resolve its entrypoint on the CI Node version and never serves, so the e2e job timed out. Build the example once and serve the static output with sirv instead. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014F14pjZxadmtLq8uTuzwXb

Align examples on a shared data-testid for successful identifies, flip React via pnpm overrides instead of sed, and verify the installed React major in CI.

…fetch

github-actions · 2026-07-21T11:40:09Z

Coverage report

St.^❔	Category	Percentage	Covered / Total
🟢	Statements	96.41% (+10.04% 🔼)	161/167
🟢	Branches	94.79% (+21.79% 🔼)	91/96
🟢	Functions	97.92% (+11.38% 🔼)	47/48
🟢	Lines	96.89% (+10.42% 🔼)	156/161

Test suite run success

42 tests passing in 16 suites.

Report generated by 🧪jest coverage report action from fb82343

Show full coverage report

St	File	% Stmts	% Branch	% Funcs	% Lines	Uncovered Line #s
🟢	All files	96.4	94.79	97.91	96.89
🟢	src	98.87	97.5	100	98.85
🟢	detect-env.ts	95	91.66	100	95	87
🟢	env.ts	100	100	100	100
🟢	env.types.ts	100	100	100	100
🟢	...nt-context.ts	100	100	100	100
🟢	get-env.ts	100	100	100	100
🟢	ssr.ts	100	100	100	100
🟢	...sitor-data.ts	100	100	100	100
🟢	src/components	100	100	100	100
🟢	...-provider.tsx	100	100	100	100
🟢	...vironment.tsx	100	100	100	100
🟢	src/utils	88.09	87.5	92.3	90
🟢	...is-defined.ts	100	100	100	100
🟢	...-cache-key.ts	80.76	83.33	85.71	84	5,10,43,52
🟢	to-error.ts	100	100	100	100
🟢	...mise-store.ts	100	100	100	100

Co-authored-by: Dan McNulty <212590662+mcnulty-fp@users.noreply.github.com>

JuroUhlar · 2026-07-22T14:33:26Z

@copilot resolve the merge conflicts in this pull request

Copilot · 2026-07-22T14:37:00Z

@copilot resolve the merge conflicts in this pull request

Addressed in 6ea1e4a.

Copilot

Pull request overview

This PR strengthens test coverage around provider initialization/rebuild behavior, SSR usage, hook race/error handling, and environment detection, while removing low-value tests and deleting an unused wait-until utility.

Changes:

Added targeted tests for FingerprintProvider (Next.js integrationInfo, force rebuild, custom agent loader fallback, provider-level getOptions merge, SSR guard).
Expanded useVisitorData coverage for mid-flight option changes, null params rejection, and error normalization/preservation.
Improved environment detection coverage (no-window path; getEnvironment parsing vs detection fallback) and removed dead/low-signal tests and helpers.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/utils/wait-until.ts	Removes an unused async polling helper.
tests/with-environment.test.tsx	Drops a low-value props echo test.
tests/use-visitor-data.test.tsx	Adds coverage for race/error paths and stricter error handling expectations.
tests/fpjs-provider.test.tsx	Adds coverage for provider init/rebuild behavior, SSR guard, Next detection, and option merging.
tests/detect-env.test.ts	Adds coverage for window-unavailable detection and `getEnvironment` JSON parsing fallbacks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

github-actions · 2026-07-23T15:00:40Z

🚀 Following releases will be created using changesets from this PR:

@fingerprint/react@3.1.0

Minor Changes

Behavior bug fixes:
- Stale automatic useVisitorData requests (when immediate changes from true to false during an automatic request) no longer overwrite state (the result is ignored).
- Loading state is now correctly synchronized when immediate changes.
We recommend double-checking that your implementation isn't relying on the previous incorrect behavior when upgrading. (ba26003)
Add support for React 19 and Next.js 16. The react peer range now accepts >=18 <20. (5307b3b)

Patch Changes

Bump @fingerprint/agent dependency to ^4.1.2 and drop the fast-deep-equal runtime dependency in favor of an internal cache-key comparison. (87b776f)

JuroUhlar and others added 25 commits July 17, 2026 08:39

fix: declare Node engine requirement in Next example apps

1ff896f

Next.js 16 requires Node >=20.9.0; declare it explicitly so contributors on older Node get a clear engine error instead of a confusing runtime failure.

chore: update CI workflow name for clarity

f999113

ci(e2e): harden workflow validation

943e78e

test(e2e): harden visitor-id assertion and React 19 switch

1dd3d8d

Align examples on a shared data-testid for successful identifies, flip React via pnpm overrides instead of sed, and verify the installed React major in CI.

chore: region param optional

eda0ea9

chore: clean up

7dd5fe7

chore: tighten EXAMPLES key typing with satisfies

b4cfbc1

test(e2e): validate production builds

bca2da5

fix(examples): guard optional region env access

f83b75f

chore: fold preact typecheck into example build

c9b927f

fix(examples): drop deprecated TypeScript 6 compiler options

c1cabef

fix: address Copilot review on example name check and env reads

8e2846b

fix: avoid setState-in-effect and stale responses in immediate mount …

0bf9954

…fetch

refactor: share query state helpers in useVisitorData

8aca20e

test: clarify stale immediate response race coverage

df6eefc

Merge origin/main into inter-2322/use-visitor-data-mount-fetch

ad87c55

fix: handle immediate query state transitions

1e21294

test: close coverage gaps and drop dead wait-until helper

5bf49cb

JuroUhlar and others added 4 commits July 21, 2026 13:51

chore: changeset

f1671b0

fix: clarify automatic fetch error handling

61c2213

fix: docs phrasing

29f44f9

Co-authored-by: Dan McNulty <212590662+mcnulty-fp@users.noreply.github.com>

fix: dont mix promises and async-await

acb5058

Co-authored-by: Dan McNulty <212590662+mcnulty-fp@users.noreply.github.com>

Base automatically changed from inter-2322/use-visitor-data-mount-fetch to main July 22, 2026 14:22

Copilot started work on behalf of JuroUhlar July 22, 2026 14:34 View session

Merge branch 'main' into test/coverage-gaps-and-cleanup

6ea1e4a

Copilot finished work on behalf of JuroUhlar July 22, 2026 14:37

JuroUhlar added 4 commits July 23, 2026 14:08

test: keep coverage cleanup API-neutral

499278d

test: avoid provider runtime changes

d38ad11

chore: add comment

08103c9

test: remove private utility coverage

bcd57ca

JuroUhlar requested a review from Copilot July 23, 2026 12:45

Copilot started reviewing on behalf of JuroUhlar July 23, 2026 12:46 View session

Copilot AI reviewed Jul 23, 2026

View reviewed changes

Comment thread __tests__/use-visitor-data.test.tsx

JuroUhlar added 2 commits July 23, 2026 15:06

test: strengthen visitor data behavior coverage

c8f011a

test: restore mocks before each visitor data test

0ce763b

JuroUhlar requested a review from Copilot July 23, 2026 13:15

Copilot started reviewing on behalf of JuroUhlar July 23, 2026 13:15 View session

Copilot AI reviewed Jul 23, 2026

View reviewed changes

Comment thread __tests__/detect-env.test.ts Outdated

test: restore the original window descriptor

06e6595

JuroUhlar changed the title ~~test: close coverage gaps and drop dead wait-until helper~~ INTER-2348: Close coverage gaps and drop dead wait-until helper Jul 23, 2026

JuroUhlar marked this pull request as ready for review July 23, 2026 13:23

JuroUhlar requested review from TheUnderScorer, ilfa and mcnulty-fp as code owners July 23, 2026 13:23

mcnulty-fp previously approved these changes Jul 23, 2026

View reviewed changes

Comment thread __tests__/fpjs-provider.test.tsx Outdated

chore: rename to getDefaultStartOptions

fb82343

JuroUhlar dismissed mcnulty-fp’s stale review via fb82343 July 23, 2026 14:59

JuroUhlar requested a review from mcnulty-fp July 23, 2026 15:00

mcnulty-fp approved these changes Jul 23, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

INTER-2348: Close coverage gaps and drop dead wait-until helper#208

INTER-2348: Close coverage gaps and drop dead wait-until helper#208
JuroUhlar wants to merge 44 commits into
mainfrom
test/coverage-gaps-and-cleanup

JuroUhlar commented Jul 21, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 21, 2026 •

edited

Loading

Uh oh!

JuroUhlar commented Jul 22, 2026

Uh oh!

Copilot AI commented Jul 22, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

JuroUhlar commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Verification

Uh oh!

github-actions Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage report

Test suite run success

Uh oh!

JuroUhlar commented Jul 22, 2026

Uh oh!

Copilot AI commented Jul 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 23, 2026

🚀 Following releases will be created using changesets from this PR:

@fingerprint/react@3.1.0

Minor Changes

Patch Changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

JuroUhlar commented Jul 21, 2026 •

edited

Loading

github-actions Bot commented Jul 21, 2026 •

edited

Loading