Closed
Conversation
magik6k
reviewed
Jul 24, 2024
Collaborator
magik6k
left a comment
magik6k
left a comment
There was a problem hiding this comment.
Seeded to stare at this for a bit to figure out the flows, but in general looks good.
Would be great to test this somehow, I don't think any of us will use this feature any time soon, so having that test is quite important.
Would also be nice to implement some small Go server implementing some simple policy like round-robin serving this API - mostly as a base for people to take and modify to fit their needs
Contributor
Author
|
Also the Do() error cases need intelligent handling so as not to fail tasks on scheduling-server down. |
snadrus
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a sketch of a dramatically simpler system than what we had before.
There was as little change as possible to the task engine: I just needed a way to peaceably return the task to the queue without a failure getting logged.
It's not a perfect system (see downsides), but it's so much simpler to reason about that I think we can verify that it would work.
Notice the interface passthru.