Feature/shops limited inventory playtesting update - #166
Conversation
Edit -sli inventory levels based on playtesting:
- Atlas Armlet, Dragoon Boots --> 1
- Earrings: {1,4} --> {1,2}
- Fenix Down: {1,5} --> {1,4}
- Basic Healing: {2-8} --> {2,6}
- High Healing: {1,3} --> {1,2}
fix earrings
There was a problem hiding this comment.
Code Review
This pull request updates shop item configurations by adding "Atlas Armlet" and "DragoonBoots" to the excluded items list, and adjusting the pack sizes for various items (relics, basic healing, and high healing items). The review feedback points out a minor PEP 8 spacing issue in the newly added earrings logic and identifies an outdated comment regarding the Fenix Down pack size range that needs to be updated to match the code changes.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Under -nfh the Returners Hideout inn is converted to a paid inn, but its insufficient-funds path cleared the NOT_ENOUGH_GP event bit and returned silently, unlike every other paid inn which displays a 'not enough money' box. Add the vanilla dialog (id 2748) on that failure path, matching the airship and phantom train heal reworks. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Rfst7BcduwiRTJeokBS8vq
Under -nfh the Figaro Castle rest is converted to a paid inn, but like the Returners Hideout inn (fixed in 377f8dc) its insufficient-funds path cleared the NOT_ENOUGH_GP event bit and returned silently. Show the same vanilla 'not enough money' dialog (id 2748) on that failure path. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0114TxZu9DpKmuNL18w81s7v
…-uis3f0 Bugfix: include the "Not enough money..." dialog for Figaro Castle Inn & Returners Hideout Inn
PEP 8 comma spacing Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Commentary update to match code Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Edited shop inventory ranges based on playtesting, as follows: