Matrix view - #9
Conversation
add linters
* Added WienerLinien disruption info (lines and elevators) (fewieden#3) * Added functions to display interuptions to lines and elevators * Added .gitignore from MM * Fixed typos in README.md * Changed line disruptions text to full description * removed unused property * Fixed lint errors * Fixed README for config parameter name change * removed project unrelated gitignores * github templates * translations, changelog and cleanup of pr fewieden#3
|
I really like the looks of it! |
fruestueck
left a comment
fruestueck
left a comment
There was a problem hiding this comment.
Overall I really like the matrix view.
It would also give us the possabillity to aggregate all stations into one view without rotating between them later (I'm only using three stations).
| /* eslint-disable func-names */ | ||
| /* eslint-disable prefer-arrow-callback */ | ||
| /* eslint-disable no-var */ | ||
| /* eslint-disable vars-on-top */ |
There was a problem hiding this comment.
This just disables some linting warnings, you can get rid of it, then you will see a few warnings
| for (let i = 0; i < this[type].length; i += 1) { | ||
| for (var i = 0; i < this[type].length; i += 1) { |
There was a problem hiding this comment.
I am using an old ipad as magic mirror device. And the old safari version does not work with let, this is why I use vars. (on newer browsers it also works with let)
| let temp = text; | ||
| var temp = text; | ||
|
|
There was a problem hiding this comment.
Same here (var)?
newline not necessary. Style thing thou.
|    | ||
|     | ||
|
|
||
|
|
||
| Matrix view | ||
|  |
There was a problem hiding this comment.
Added images are to big.
I'd also reduce the amount of images. Maby swap example-matrix with example2. Should be enoth.
| | `api_key` | REQUIRED | Get an API key for free access to the data of www.wienerlinien.at [here](https://www.wien.gv.at/formularserver2/user/formular.aspx?pid=3b49a23de1ff43efbc45ae85faee31db&pn=B0718725a79fb40f4bb4b7e0d2d49f1d1). | | ||
| | `stations` | REQUIRED | Insert here the station ids you want to display data from [How to find an ID?](https://till.mabe.at/rbl/). | | ||
| | `max` | `5` | How many departures should be displayed. | | ||
| | `display` | `list` | Show departures as list or as `matrix` (see screenshots). | |
There was a problem hiding this comment.
Both options - matrix and list -should be highlighted.
3 participants
Added a new matrix view (i.e. one line per destination with several departure times)
Screenshot: