Repository navigation
Drop stale packaging files and unused Black config - #254
Draft
BlivionIaG wants to merge 2 commits into
Draft
BlivionIaG wants to merge 2 commits into
BlivionIaG wants to merge 2 commits into
Conversation
requirements.txt disagreed with the pyproject dependency floors and nothing referenced it. CI formats with ruff, so the Black extra and config go away. Package data keeps the yml and json resources; Python modules stay via packages.find. The Homebrew formula no longer points at a missing v3.0.0 tarball. Co-authored-by: BlivionIaG <BlivionIaG@users.noreply.github.com>
The lock still listed black as a dev extra after pyproject stopped doing so. click, platformdirs, and pytokens existed only for Black. Other pins are unchanged. Co-authored-by: BlivionIaG <BlivionIaG@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
One dependency and tooling source of truth.
pyproject.tomlalready declares the runtime floors, the ruff formatter CI runs, and the package layout. This removes copies and config that disagree with that or do nothing.requirements.txt. Its floors (pypresence>=4.3.0,psutil>=5.9.0,pyyaml>=6.0.1) disagree with[project.dependencies], and nothing in the repo references the file.blackdev extra, the whole[tool.black]block, and the Black entries inuv.lock(black, plusclick,platformdirs, andpytokens, which nothing else depends on). Other lock pins are unchanged. CI usesruff format --check. The E501 ignore comment now names ruff format."tests/**/*.py" = ["S"]. The lint select list does not include S.[tool.setuptools.package-data], dropresources/*.pyandnative/**/*.py.packages.findalready ships those modules. The yml and json globs stay.Formula/fetchcord.rb: drop theurl/sha256for a nonexistentv3.0.0tag (the sha was zeros).headstays. The comment that only explained the missing tag is gone; the local--HEADinstall note stays.fetchcord.spec: drop the stale*.confmention. Conf resources were removed in 3.0. Thecollect_data_filescall is unchanged.MANIFEST.in. A build without it still packs the yml and json resources (see Results).Draft PR #253 is open and does not touch these files. Detection, presence, Windows
system_type, andscripts/validate.pyare unchanged.scripts/update_formula.pyonly rewrites existingurl/sha256lines. The tap formula is a separate repo. This in-tree formula is head-only until a real tag exists and those lines are added back on the tap.Test plan
rgforrequirements.txt,MANIFEST.in, andblackafter the editpython -m buildwithoutMANIFEST.in: sdist and wheel still containfetch_cord/resources/*.ymland*.json, plus the Python modules frompackages.findpip install -e ".[dev]"(Black is not installed)ruff check .ruff format --check .mypy fetch_cord testspython -m pytest tests/ -q --cov=fetch_cord --cov-fail-under=80python -m buildon the committed treeuv.lockstill parses, and every locked dependency name resolves to a packageResults
Python 3.12.3 in a venv (
pythonis not onPATHhere). Commands match.github/workflows/ci.yml, pluspython -m build.Sdist resources after deleting
MANIFEST.inand the*.pypackage-data globs (setuptools 84.0.0). The wheel has the same yml/json files. Native*.pymodules are in both archives viapackages.find.uvis not installed in this environment, so the lock was edited by hand and checked withtomllib: no dangling dependency names, and the dev extra matchespyproject.toml.