Skip to content

fix(app): snapshrot batch slice before despatch to prevent stack corruption #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
debuggerdragon311 merged 1 commit into from
Jun 14, 2026
Merged

fix(app): snapshrot batch slice before despatch to prevent stack corruption #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 27 additions & 8 deletions src/app/app.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,18 +590,37 @@ fn dispatchCmd(
switch (c) {
.none => return false,
.quit => return true,

.batch => |cmds| {
for (cmds) |sub| {
if (try dispatchCmd(MsgT, sub, queue, cmd_pipe_w, alloc)) return true;
const INLINE_CAP: usize = 16;
if (cmds.len <= INLINE_CAP) {
var snap: [INLINE_CAP]Cmd(MsgT) = undefined;
@memcpy(snap[0..cmds.len], cmds);
for (snap[0..cmds.len]) |sub| {
if (try dispatchCmd(MsgT, sub, queue, cmd_pipe_w, alloc)) return true;
}
} else {
const heap_snap = try alloc.dupe(Cmd(MsgT), cmds);
defer alloc.free(heap_snap);
for (heap_snap) |sub| {
if (try dispatchCmd(MsgT, sub, queue, cmd_pipe_w, alloc)) return true;
}
}
return false;
},

// v1: treats .sequence as concurrent (ordered delivery deferred to v2).
.sequence => |cmds| {
for (cmds) |sub| {
if (try dispatchCmd(MsgT, sub, queue, cmd_pipe_w, alloc)) return true;
.sequence => |seq_cmds| {
const INLINE_CAP: usize = 16;
if (seq_cmds.len <= INLINE_CAP) {
var snap: [INLINE_CAP]Cmd(MsgT) = undefined;
@memcpy(snap[0..seq_cmds.len], seq_cmds);
for (snap[0..seq_cmds.len]) |sub| {
if (try dispatchCmd(MsgT, sub, queue, cmd_pipe_w, alloc)) return true;
}
} else {
const heap_snap = try alloc.dupe(Cmd(MsgT), seq_cmds);
defer alloc.free(heap_snap);
for (heap_snap) |sub| {
if (try dispatchCmd(MsgT, sub, queue, cmd_pipe_w, alloc)) return true;
}
}
return false;
},
Expand Down
Loading