Skip to content

Add unit test coverage for GetForUser goal controller route#279

Open
1Dhairyak wants to merge 1 commit into
fencer-so:mainfrom
1Dhairyak:add-goal-icon-tests
Open

Add unit test coverage for GetForUser goal controller route#279
1Dhairyak wants to merge 1 commit into
fencer-so:mainfrom
1Dhairyak:add-goal-icon-tests

Conversation

@1Dhairyak

Copy link
Copy Markdown

Summary

Adds xUnit test coverage for the GetForUser endpoint on GoalController, completing the test cases for goal retrieval by user.

Changes

  • Implemented the previously empty GetForUser test in GoalControllerTests.cs
  • Test verifies that goals returned for a given user ID match expected Id and Name values, following the existing pattern used in GetAll and Get
  • Verified with dotnet test: 11/11 tests passing, no regressions

Testing

Ran dotnet test locally — all tests pass.

@gitguardian

gitguardian Bot commented Jul 5, 2026

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - MongoDB Credentials ed9f374 CommBank-Server/Secrets.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant