Skip to content

feat: add icon support to Goal model with unit tests#275

Open
alwaysprince05 wants to merge 2 commits into
fencer-so:mainfrom
alwaysprince05:feature/icon-support
Open

feat: add icon support to Goal model with unit tests#275
alwaysprince05 wants to merge 2 commits into
fencer-so:mainfrom
alwaysprince05:feature/icon-support

Conversation

@alwaysprince05

Copy link
Copy Markdown

Summary

This PR adds icon support to the CommBank backend and extends test coverage.

Changes

Goal Model (Task 1)

  • Added optional Icon field (string?) to Goal.cs
  • Icons persist to MongoDB

Tests (Task 4)

  • Implemented GetForUser test in GoalControllerTests.cs
  • Asserts result not null, each goal is a Goal type, each goal has expected UserId
  • All 11 tests pass

Testing

dotnet test → 11 passed, 0 failed

@gitguardian

gitguardian Bot commented Jul 2, 2026

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - MongoDB Credentials a85b835 CommBank-Server/Secrets.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant