Conversation
…Some adjustments in mvn lifecycle for spring boot applications
Contributor
Author
|
Jeg la ikke til mvn lifecycle i quarkus, AIen sa quarkus ikke støttet det per nå. Har ikke lagt til maven clean i ci-pr-checks-image, regner med den starter opp en ny kånteiner når den starter opp. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR splits the existing “golden path” PR checks workflow into two reusable workflows—one tailored for Maven library repositories and one for containerized applications—while deprecating the previous combined ci-pr-checks.yml. It also adjusts the Spring Boot container scan workflow to support configurable Maven lifecycle phases and test skipping.
Changes:
- Introduces
ci-pr-checks-lib.yml(Maven libraries) andci-pr-checks-image.yml(containerized apps) as replacements forci-pr-checks.yml. - Updates Spring Boot container scan to accept
maven-lifecycleandmaven-skip-testsinputs and uses them in the Maven build command. - Updates documentation and workflow headers/comments to reflect the new split and deprecation.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates docs to point to the new split PR-check workflows and marks the old one as deprecated. |
| .github/workflows/ci-spring-boot-container-scan.yml | Adds Maven lifecycle/test-skip inputs and uses them when building Spring Boot images. |
| .github/workflows/ci-quarkus-container-scan.yml | Updates header comments to reference ci-pr-checks-image. |
| .github/workflows/ci-pr-checks.yml | Marks the existing combined workflow as deprecated in-file. |
| .github/workflows/ci-pr-checks-lib.yml | Adds new reusable workflow for Maven library PR checks (build/test + Trivy FS scan + optional artifact + optional auto-merge). |
| .github/workflows/ci-pr-checks-image.yml | Adds new reusable workflow for containerized app PR checks delegating to Spring Boot/Quarkus container scan workflows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
oyri
reviewed
Jun 18, 2026
oyri
reviewed
Jun 18, 2026
oyri
approved these changes
Jun 18, 2026
oyri
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…Some adjustments in mvn lifecycle for spring boot applications