Skip to content

Shorten encodedGitDir if necessary - #1345

Closed
jtmuller5 wants to merge 1 commit into
felangel:masterfrom
jtmuller5:master
Closed

jtmuller5 wants to merge 1 commit into
felangel:masterfrom
jtmuller5:master

Conversation

@jtmuller5

Copy link
Copy Markdown

Status

READY

Description

This is a fix for this issue. When the git URL is too long, the file name generated exceeds 256 characters and the mason get command fails.

This change checks the length of the output file name and shortens name_url section of the output if necessary.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • [ x] 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@jtmuller5
jtmuller5 requested a review from felangel as a code owner June 11, 2024 20:08
@felangel

felangel commented Jun 12, 2024

Copy link
Copy Markdown
Owner

This isn't specific to bricks from git (see #496 and #759) so the real fix should be to generically handle this for all brick paths. I'll try to work on this shortly 👍

@felangel felangel closed this Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants