refactor(adapters): simplify vLLM and SGLang ownership - #193
Merged
feichai0017 merged 2 commits intoSep 30, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
feichai0017
merged commit Sep 30, 2026
8c495d0
into
feat/s2-metadata-qualification
12 of 13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The adapters loaded native/GPU modules during plugin discovery and retained an unused vLLM availability owner and health thread. This cleanup loads only the selected vLLM role, closes native connections after initialization failure, uses the pinned engine's unchanged optional callback defaults, and reports registration conflicts explicitly. SGLang graph-event ownership moves into
events.py, with unselected backend hooks remaining lightweight. Existing page-retention, recovery and P/D lifecycle owners remain in place.This PR targets the accepted
feat/s2-metadata-qualificationbaseline so its diff contains only the two adapter-cleanup commits (61b2ac0e,13bd405a). The adapter guide records the pinned LMCache/FlexKV references and ownership boundaries. No native ABI or Rust implementation changes are included.Validation:
Two initial SSD starts exposed a test-harness port bug: loopback availability did not imply wildcard availability for TCPStore. A standalone reproduction confirmed it; the helper now checks wildcard listening and has a real-socket regression test. The fixture now preserves Manager logs. Failed-run evidence is retained; the original fixture had already deleted its first-run temporary Manager logs.
External reviewer handoff:
/root/orbitkv-artifacts/adapter-cleanup-20260930/HANDOFF.txt. Downloaded logs and hash manifest:remote-evidence/in that directory. Full A100 runs:/workspace/orbitkv-adapter-cleanup-20260930/. Qualification and remaining work are recorded in completion-plan S5.2; independent review, engine upgrades and broader multi-GPU/P/D qualification remain open.