Conversation
KrauseFx
approved these changes
May 10, 2017
KrauseFx
left a comment
KrauseFx
left a comment
Member
There was a problem hiding this comment.
This is great! One small change, then you can merge 👍
We currently don't run those code style verification on CI, is that something we want to invest time in? Maybe we should just use HoundCI for this one, as it's really easy to setup, and shows inline style errors? We've used it for fastlane in the past too.
| @@ -0,0 +1 @@ | |||
| inherit_from: .rubocop_todo.yml No newline at end of file | |||
Collaborator
Author
There was a problem hiding this comment.
need to install ymlcop 🙃
Member
|
Small merge conflict, then it's ready to be merged 👍 |
Member
|
After merging the 4 newly added PRs, we should rebase this and get it running 👍 |
Collaborator
Author
|
I somehow thought I merged this already 🤦♂️ |
Member
|
This can be rebased now 👍 |
Member
|
Ok ok :) |
Member
|
@taquitos You want to rebase this and get it merged in? 😈 |
Collaborator
Author
|
I think the merge was good but haven't tested yet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used the fastlane rubocop yaml file