Repository navigation
Conversation
Puppo
changed the title
Puppo
marked this pull request as ready for review
August 2, 2026 16:00
undici@8.x requires Node.js >=22.10 (it uses worker_threads.markAsUncloneable, added in 22.10.0), which breaks the test suite on Node 20 (see dependabot PRs fastify#112, fastify#116, fastify#118, fastify#121, fastify#122). The package only uses undici as a test HTTP client - nothing in the runtime depends on it - so the dependency is removed entirely. A small test/helpers/request.js wrapper around node:http and node:https keeps the existing test code shape (request(url) -> res.body.json()) and scopes self-signed-cert acceptance to the HTTPS path via a per-request https.Agent({ rejectUnauthorized: false }), with no process-level side effects.
Member
|
what's the problem in keeping undici 7? |
Member
Author
The only problem is that we cannot upgrade to undici 8 because it is not Node 20 compatible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops
undicias a devDependency and replaces the test HTTP client with a smalltest/helpers/request.jswrapper aroundnode:http/node:https. This unblocks the queued dependabot PRs (#112, #116, #118, #121, #122) that have all been failing on Node 20 becauseundici@8.xrequires Node>=22.10.0(it usesworker_threads.markAsUncloneable, which landed in 22.10).