Repository navigation
fix(types): type handler as websocket handler in route() with websocket: true - #382
Merged
Merged
Conversation
Tony133
marked this pull request as ready for review
October 1, 2026 08:13
ilteoood
approved these changes
Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal:
When using the full declaration syntax with
websocket: true,handleris the websocket handler at runtime, but it was typed as a regular HTTP handler, sosocketwas inferred asFastifyRequestandrequestasFastifyReply. The shorthand methods already had awebsocket: trueoverload;route()did not.This adds the equivalent overload for
route(), typinghandlerasWebsocketHandlerwhenwebsocket: true, including generics and type provider inference.Note:
wsHandleralongsidewebsocket: truestill compile as before. RejectingwsHandlerwhenwebsocket: true(it is ignored at runtime) could be a follow-up, but would be a breaking change for types.websocket: falseroute to make sure HTTP handlers are unchanged. The new assertions fail without the fix.Fixes #314