Repository navigation
Conversation
Puppo
marked this pull request as ready for review
October 7, 2026 09:58
ilteoood
approved these changes
Oct 7, 2026
Member
|
Closing this, it seems that has been merged somewhere else |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow currently skips Swagger UI asset preparation: the repository sets
ignore-scripts=truein.npmrc, and the shared workflow runsnpm run --if-present release:build, but that script is missing. AutomaticprepareandprepublishOnlyhooks therefore do not generate the assets during publication. npm documents this behavior.Adds
"release:build": "npm run prepare"so the shared workflow explicitly generates static UI files, branding, OAuth redirect assets, andcsp.jsonbefore publication. Explicitnpm runcommands still execute with scripts disabled. This changes only one line inpackage.jsonand preserves the existing hooks.Addresses the review on #294. That PR has merged; this is a separate follow-up against current
main.Validation
Tested with Node.js 24.21.0 and npm 11.19.0:
npm install --ignore-scripts --no-audit --no-fundpassed; confirmed no static assets were generated during installation.npm config get ignore-scriptsreturnedtrue.npm run --if-present release:buildpassed and generated all 12 required nonempty static files.npm pack --json --ignore-scriptspassed; verified the tarball contains all 12 assets, runtime/declaration entry points, and validcsp.json.npm run lintpassed.npm testpassed: unit tests with 100% coverage and declaration tests. Local networking used per-processNODE_OPTIONS=--dns-result-order=ipv4first.The separate Playwright browser E2E suite was not run locally. Package version remains 6.1.1. No release workflow was dispatched and no package was published.