Repository navigation
fix: normalize vary header handling to prevent duplicate or omitted accept-encoding - #436
Merged
Tony133 merged 1 commit intoOct 13, 2026
Conversation
…ccept-encoding Signed-off-by: Talha Shafeeq <talha.shafeeq.ts@gmail.com>
Tony133
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #435
What kind of change does this PR introduce?
Description
Fixes
setVaryHeader(reply)inindex.jsto correctly parse, normalize, and respectVaryheaders:accept-encodingregardless of casing (e.g.Vary: Accept-Encoding), preventing duplicateVary: Accept-Encoding, accept-encodingheaders..includes('accept-encoding')) with tokenization by commas and trimming whitespace. This prevents false positives when custom vary headers containaccept-encodingas a substring (e.g.x-accept-encoding), ensuringaccept-encodingis legitimately appended.Vary: *without incorrectly appending, accept-encoding.Checklist
npm run test