Repository navigation
refactor(index): enforce strict regex - #178
Merged
Merged
Conversation
`u` unicode flag is equivalent to `'use strict'` directive in JS Signed-off-by: Frazer Smith <frazer.dev@icloud.com>
There was a problem hiding this comment.
Pull request overview
This PR adds the u (unicode) flag to four regular expression patterns in the Basic Auth plugin to enforce stricter and more predictable regex behavior.
Key changes:
- Added
uflag tocredentialsStrictREandcredentialsLaxRE(combining with existingiflag) - Added
uflag tocontrolREanduserPassREpatterns
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Contributor
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uunicode flag is equivalent to'use strict'directive in JSChecklist
npm run test && npm run benchmark --if-presentand the Code of conduct