Repository navigation
refactor: splitting package into constituent modules - #297
Closed
nhankyjangchan wants to merge 1 commit into
Closed
nhankyjangchan wants to merge 1 commit into
nhankyjangchan wants to merge 1 commit into
Conversation
… general cleaning and reworking of code without changing the API - Renaming the entry point from auth.js to index.js with corresponding changes in the package manifest - Splitting a monolithic module into separate submodules, logically splitting functionality into separate functions - Updated error messages with corresponding test adjustments - Clarification of typing in modules, addition of new auxiliary types Signed-off-by: nhankyjangchan <dev.schuchkin.timur@gmail.com>
Fdawgs
requested changes
Sep 11, 2026
Fdawgs
left a comment
Fdawgs
left a comment
Member
There was a problem hiding this comment.
Whilst i'm sure some of this is reasonable, squashing it all into an AI-generated commit and PR isn't.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work performed
For what?
Clean code makes a project easier to maintain and more stable to develop. In this work, I was largely guided by Bob Martin's work, Clean Code, but I also kept in mind that not all of his advice should be followed in practice. The main focus was choosing more meaningful names for entities, separating large or reusable entities into modules, and breaking down large functions into smaller ones to reduce the responsibilities of each.
Verified before pull request
npm run lint:fix && npm run lint && npm run test