Repository navigation
Conversation
Traverse schema-valued keywords and subschema containers explicitly so const, enum, annotations and property-dependency data remain unchanged. Add regression coverage for union selection and supported schema shapes. Prepared with AI assistance for human review.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
convertSchemaToAjvFormatpreviously performed a blind recursive traversal over all object properties. When literal data keywords (such asconst,enum,default,examples, or custom annotations) contained objects with atypeproperty (e.g.,{ type: 'string' }), the converter incorrectly treated them as subschemas, modifying their structure and corrupting the literal data.Solution
Replaced naive recursion with explicit traversal of subschema containers:
schemaKeywords), array (schemaArrayKeywords), and map structures (schemaMapKeywords).const,enum,default,examples, and unknown annotation keywords untouched.Verification
Added regression tests in
test/validator-schema-traversal.test.js:constandenumwithinanyOf/oneOfare preserved.default,examples, and customx-annotations remain unmodified.AI assistance
The implementation and regression tests were prepared with AI assistance and reviewed by me.
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct