Repository navigation
fix: honor explicit ajv strictSchema option - #901
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #673.
Honor explicit
ajv.strictSchema: trueor'log'instead of always overwriting the option withfalse. The permissive default stays unchanged, includingstrict: truewithout an explicitstrictSchemasetting. Other enforced Ajv options are unchanged.Added 18 regression cases covering lazy and eager validator compilation, errors, warnings and defaults. The README clarifies that this only affects schema paths compiled by Ajv, not every schema processed by fast-json-stringify.
Validation on Node 24.19.0:
npm run benchmark --if-presentcompleted successfully on Node 24.19.0. These are local validation results, not a claim that upstream CI has passed.Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct