Repository navigation
fix: scope largeArrayMechanism options per build() call - #899
Merged
Merged
Conversation
largeArraySize and largeArrayMechanism were module-level state that build() mutated and never reset, so an unrelated build() call opting into 'json-stringify' for its own schema leaked into every serializer built afterwards, even ones built with no options. This silently defeated the documented schema filtering (missing fields / additionalProperties: false). Move both values onto the per-build context and branch on them there. Add a regression test that builds a serializer without options after a json-stringify build and asserts filtering is preserved.
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scopes
largeArraySizeandlargeArrayMechanismto eachbuild()call instead of module-level state.Previously these two values were module globals that
build()mutated and never reset, so any unrelatedbuild()call opting intolargeArrayMechanism: 'json-stringify'leaked into every serializer built afterwards — even ones built with no options. That silently disabled the schema filtering (missing fields /additionalProperties: false) for unrelated schemas, which is what Fastify relies on to redact fields from responses.The fix moves both options onto the per-build
contextobject and branches on them there. A regression test builds a serializer without options after ajson-stringifybuild and asserts filtering is still applied.Fixes GHSA-jqm2-x2jx-52q2.