Repository navigation
Conversation
gurgunday
requested changes
Oct 21, 2026
gurgunday
left a comment
gurgunday
left a comment
Member
There was a problem hiding this comment.
- Same bug in asTime lib/serializer.js:122 should be fixed
- Tests belong in test/date.test.js
Author
|
Addressed both requests in 24c39ea: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serializing a valid JavaScript Date in year 10000 with
format: "date"currently returns"+010000-02", dropping the day. Negative expanded years are truncated in the same way. Trim the fixed ISO time suffix so the complete calendar date is preserved, while four-digit-year output stays the same.Validation: two added expanded-year regressions fail on the original implementation; two ordinary-year controls pass. The patched full suite passes 590 unit tests with 100% coverage, 15 TypeScript assertions, and ESLint.