Repository navigation
fix: preserve allOf property constraints with additionalProperties false - #890
Merged
Merged
Conversation
Tony133
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #684.
Temporarily leave root
additionalProperties: falseout of the allOf merge, then restore it on the merged schema. This keeps nested coercion and required checks active while still dropping undeclared output properties. Explicittrueand schema-valued additionalProperties keep their existing behavior.Adds regressions for nested array properties, referenced/root constraints, required fields, and additional-property schemas. The nested coercion case fails on main.
Full tests pass on Linux with Node 20, 22, 24 and 26: 589 runtime tests, 100% coverage and 15 TypeScript assertions. ESLint and production license checks pass. Extra recursive/reference, patternProperties and input-immutability checks pass. macOS/Windows and dependency review are left to upstream CI.