Repository navigation
feat(types): allow string schema with separator for string[] properties - #248
Open
hoanle0126 wants to merge 1 commit into
Open
hoanle0126 wants to merge 1 commit into
hoanle0126 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct
Description
Fixes #157
Currently,
env-schemare-exports Ajv'sJSONSchemaType<T>directly. Becauseenv-schemaregisters the custom modifyingseparatorkeyword ontype: 'string'schemas to split strings intostring[]at runtime, typing an interface property asstring[]while defining its schema as{ type: 'string', separator: ',' }fails TypeScript validation (Type '"string"' is not assignable to type '"array"').This PR updates
envSchema.JSONSchemaType<T>so properties typed asstring[](orreadonly string[]) inTaccept either a standardarrayschema or atype: 'string'schema with a requiredseparator: stringproperty, while preserving automatic generic return type inference onenvSchema({ schema }).