Repository navigation
Need to get full header聽#127
Description
Prerequisites
- I have written a descriptive issue title
- I have searched existing issues to ensure the feature has not already been requested
馃殌 Feature Proposal
I need to get the full raw headers from each field, as is, without any modification.
Motivation
You do strip out quite a bit, and leave many things behind.
headers that are not known to you gets discarded, headers meta ;key=value pair gets discarded too.
And some things even get modified as you apply to lowercase here and there.
I need to parse the headers on my own, so it would be good if you could send the headers as a 2D iterable array
(as one header could appair twice)
// x-forwared-for: 192.168.0.1
// x-forwared-for: 192.168.0.2
headers = new Headers([
['x-forwared-for', '192.168.0.1'],
['x-forwared-for', '192.168.0.2']
])
headers.get('x-forwared-for') // 192.168.0.1, 192.168.0.2Example
the arguments length is getting out of control cuz they are so many now. and i don't need all of them... An object would be better...
- busboy.on('field', (fieldname, val, fieldnameTruncated, valTruncated, encoding, mimetype) => {
+ busboy.on('field', (field) => {
console.log(`Field [${field.fieldname}]: value: ${field.val}`);
});so that i could do:
busboy.on('field', (field) => {
console.assert(Array.isArray(field.headers))
Object.fromEntries(field.headers)
new Headers(field.headers)
})
Activity
Uzlopak commentedon Sep 30, 2023
@gurgunday
@KhafraDev
Your opinions? Afaik you wanted to replace busboy in undici with this version. Do you see any drawbacks?
jimmywarting commentedon Sep 30, 2023
fyi, related to: nodejs/undici#2283
Uzlopak commentedon Sep 30, 2023
@gurgunday
Can you please take over this issue? I am currently bound by refactoring probot as at work upgrading our github bots is stalled. So I am kind of mentally blocked to handle more than two super complex packages.
I see following tasks:
jimmywarting commentedon Sep 30, 2023
undici is probably not going to expose full headers from any field, it's just for mine and other sake of being able to know what all the headers on a given field are...
some custom libraries batch multiple request into one single multipart/form-data
https://docs.arangodb.com/3.11/develop/http/batch-requests/
So knowing all headers could be useful for others who are interested in this busboy. (like a custom express middleware)
jimmywarting commentedon Sep 30, 2023
2D array is important b/c a header could be added twice.
like set-cookie
gurgunday commentedon Sep 30, 2023
Should be doable, I'll try to take a look at this
Uzlopak commentedon Sep 30, 2023
@jimmywarting
I am not against this proposal. I just want to have a clear scope. If undici doesnt need it per se but you need it, we should maybe make it configurable with a option, which maybe could be passed down from undici to busboy.
KhafraDev commentedon Sep 30, 2023
I would expect the header parsing to allow semicolons.
jimmywarting commentedon Oct 1, 2023
Undici is going to need it to get access to the raw header in order to get the full / as is
content-typeit needs it do create a
Filewith the exact same type, as provided bycontent-type... no cut of meta key/value pairs. no lowercased transformation.(maybe also being able to parse content-disposition attachment header in a own way if needed)
undici is just not going to expose the raw headers to the client using fetch.
macgbluedev commentedon Oct 3, 2026
Hi!
I found this issue while tracking down supabase/storage#816.
I know it's an old issue, but I've opened a PR with a proposal: #231. It passes the raw part headers as a new trailing argument to the
fileandfieldevents, without breaking existing listeners.Feedback is welcome 馃槈
style(test): add missing newline at end of part-headers test