Repository navigation
Conversation
The AppRun script and the desktop entry Exec lines used the pubspec name, while Flutter builds the executable under BINARY_NAME from linux/CMakeLists.txt. When the two differ, the AppImage fails at launch with "No such file or directory". Dart: MakeAppImageConfig now extends MakeLinuxPackageConfig, like the deb and rpm configs. The metainfo file keeps the pubspec name so it still matches the .desktop file. Rust: use app_binary_name, which the CLI already resolves from CMake.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
BINARY_NAMEinlinux/CMakeLists.txtdiffers from the pubspecname, the AppImage is built without error but fails at launch:AppRunrunsexec ./<pubspec name>and the desktop entryExeclines use the same name, but Flutter builds the executable asBINARY_NAME.This is the AppImage counterpart of #312 (fixed for RPM in #313). The deb, rpm and pacman packagers already use the CMake binary name; AppImage was the remaining one.