Skip to content

⬆️ pre-commit autoupdate - #1792

Closed
alexrockhill wants to merge 3 commits into
fastapi:masterfrom
alexrockhill:feature/pre-commit-update
Closed

⬆️ pre-commit autoupdate#1792
alexrockhill wants to merge 3 commits into
fastapi:masterfrom
alexrockhill:feature/pre-commit-update

Conversation

@alexrockhill

Copy link
Copy Markdown
Contributor

I rather like having pre-commit update so that your linters don't get out-of-date and you don't get faced with a giant stack of errors.

@alexrockhill alexrockhill changed the title ENH: Add pre-commit update feat: Add pre-commit update Aug 28, 2025
@YuriiMotov YuriiMotov added the internal Internal changes label Sep 4, 2025

@YuriiMotov YuriiMotov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexrockhill, could you please remove unnecessary formatting changes to reduce the diff?

Thank you!

Comment thread .pre-commit-config.yaml
- repo: https://github.com/charliermarsh/ruff-pre-commit
rev: v0.2.2
- repo: https://github.com/charliermarsh/ruff-pre-commit
rev: v0.12.10

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rev: v0.12.10
rev: v0.12.12

@YuriiMotov YuriiMotov changed the title feat: Add pre-commit update ⬆️ Bump pre-commit hooks Sep 4, 2025
@YuriiMotov YuriiMotov changed the title ⬆️ Bump pre-commit hooks ⬆️ pre-commit autoupdate Sep 4, 2025
@alexrockhill

Copy link
Copy Markdown
Contributor Author

The extra changes are caused by the formatting updates

@YuriiMotov

Copy link
Copy Markdown
Member

@alexrockhill, could you please take a look one more time and minimize the diff?
It seems that we can just change 2 lines (rev: v4.4.0 -> rev: v6.0.0 and rev: v0.2.2 -> rev: v0.12.10)
And changes to development.md and frontend/.gitignore are not needed

Comment thread .pre-commit-config.yaml
rev: v0.12.10
hooks:
- id: ruff
- id: ruff

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- id: ruff
- id: ruff-check

@github-actions

Copy link
Copy Markdown
Contributor

As this PR has been waiting for the original user for a while but seems to be inactive, it's now going to be closed. But if there's anyone interested, feel free to create a new PR.

@github-actions github-actions Bot closed this Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Internal changes waiting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants