Skip to content
This repository was archived by the owner on Nov 2, 2020. It is now read-only.

Fix Color Test#127

Open
wjmelements wants to merge 1 commit into
facebookarchive:masterfrom
wjmelements:fix-color-test
Open

Fix Color Test#127
wjmelements wants to merge 1 commit into
facebookarchive:masterfrom
wjmelements:fix-color-test

Conversation

@wjmelements

Copy link
Copy Markdown

Changes

Fixes color test.
Reviewers @grp

@facebook-github-bot

Copy link
Copy Markdown
Contributor

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired.

Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status.

@wjmelements

Copy link
Copy Markdown
Author

As feedback for @facebook-github-bot, it would save time for me if you gave me a link to sign the CLA. Square's CLA system was vastly superior; I was able to complete it in less than a minute.

@wjmelements

Copy link
Copy Markdown
Author

In other news, your CircleCI is broken:

1.18s$ xcodebuild test -project FBTweak.xcodeproj -scheme FBTweak -sdk iphonesimulator
Build settings from command line:
    SDKROOT = iphonesimulator10.3
xcodebuild: error: Failed to build project FBTweak with scheme FBTweak.
	Reason: A build only device cannot be used to run this target.
The command "xcodebuild test -project FBTweak.xcodeproj -scheme FBTweak -sdk iphonesimulator" exited with 70.

@wjmelements

wjmelements commented Jul 10, 2018

Copy link
Copy Markdown
Author

@grp I have not received a response from cla@fb.com

Edit: now I have

@wjmelements

Copy link
Copy Markdown
Author

When I try to sign the CLA using links provided to other contributors, I get

Error notice
There were some errors submitting your CLA:

    GitHub Username is already associated with an existing contributor.

If you would like to update an existing contributor account, please email cla@fb.com with your details.

@wjmelements

Copy link
Copy Markdown
Author

Ideally, I should be able to just sign again.

@facebook-github-bot

Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants