Skip to content
This repository was archived by the owner on Nov 2, 2020. It is now read-only.

Allowed shake enablement for simulator too.#123

Open
manhluong wants to merge 1 commit into
facebookarchive:masterfrom
manhluong:master
Open

Allowed shake enablement for simulator too.#123
manhluong wants to merge 1 commit into
facebookarchive:masterfrom
manhluong:master

Conversation

@manhluong

Copy link
Copy Markdown

Allow the shake to be disabled in the simulator too.

This is useful especially if you want to show the React Native Developer menu in the simulator with a shake gesture while also using Tweaks.

_shakeEnabled is already defaulted to YES.

@facebook-github-bot

Copy link
Copy Markdown
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@emmajam

emmajam commented Jul 20, 2018

Copy link
Copy Markdown

@grp @sgl0v any chance getting this merged in ASAP? Thanks! 😄 🙏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants