Skip to content

WIP - patch react-loadable, remove UNSAFE_componentWillMount - v2 #12314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
slorber wants to merge 2 commits into from
Closed

WIP - patch react-loadable, remove UNSAFE_componentWillMount - v2 #12314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b229b0
patch react-loadable, remove UNSAFE_componentWillMount
slorber Jul 23, 2026
b5c68cc
try to remove super context
slorber Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions patches/@docusaurus__react-loadable.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
diff --git a/lib/index.js b/lib/index.js
index 1167aa26f6ad3cbacde07230386a54270e0bcdb9..a6069a0acfbac9003b68232f9e471663d54cfe03 100644
--- a/lib/index.js
+++ b/lib/index.js
@@ -159,6 +159,9 @@ function createLoadableComponent(loadFn, options) {
loading: res.loading,
loaded: res.loaded
};
+
+ this._loadModule();
+
return _this;
}

@@ -168,10 +171,6 @@ function createLoadableComponent(loadFn, options) {

var _proto = LoadableComponent.prototype;

- _proto.UNSAFE_componentWillMount = function UNSAFE_componentWillMount() {
- this._loadModule();
- };
-
_proto.componentDidMount = function componentDidMount() {
this._mounted = true;
};
31 changes: 17 additions & 14 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,5 @@ allowBuilds:
fast-folder-size: false
nx: false
sharp: false
patchedDependencies:
'@docusaurus/react-loadable': patches/@docusaurus__react-loadable.patch
Loading