Skip to content

Harden leadership lifetimes and device contracts for 1.1 - #129

Merged
f2calv merged 18 commits into
mainfrom
f2calv/2026-10-updates1
Oct 24, 2026
Merged

Harden leadership lifetimes and device contracts for 1.1#129
f2calv merged 18 commits into
mainfrom
f2calv/2026-10-updates1

refactor(ddns): skip irrelevant records before address processing

50c97b7
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Oct 24, 2026 in 14s

Quality Gate passed

Issues
83 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.2% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 134 in src/CasCap.App.Server.Tests/Infrastructure/DeviceApiWebApplicationFactory.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused method parameter 'bulbIdentifier'. 

See more on https://sonarcloud.io/project/issues?id=f2calv_SmartHaus&issues=AaFueqcaY4cSrRUGMk53&open=AaFueqcaY4cSrRUGMk53&pullRequest=129

Check warning on line 133 in src/CasCap.App.Server.Tests/Infrastructure/DeviceApiWebApplicationFactory.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make 'GetPilot' a static method. 

See more on https://sonarcloud.io/project/issues?id=f2calv_SmartHaus&issues=AaFueqcaY4cSrRUGMk5u&open=AaFueqcaY4cSrRUGMk5u&pullRequest=129

Check warning on line 78 in src/CasCap.Api.Knx.Tests/Tests/Unit/KnxLeadershipTests.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of using this literal 'connect' 6 times. 

See more on https://sonarcloud.io/project/issues?id=f2calv_SmartHaus&issues=AaFueqchY4cSrRUGMk57&open=AaFueqchY4cSrRUGMk57&pullRequest=129

Check warning on line 135 in src/CasCap.App.Server.Tests/Infrastructure/DeviceApiWebApplicationFactory.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused method parameter 'bulbIdentifier'. 

See more on https://sonarcloud.io/project/issues?id=f2calv_SmartHaus&issues=AaFueqcaY4cSrRUGMk55&open=AaFueqcaY4cSrRUGMk55&pullRequest=129

Check warning on line 40 in src/CasCap.Api.Ubiquiti/Services/UbiquitiQueryService.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Logging in a catch clause should pass the caught exception as a parameter. 

See more on https://sonarcloud.io/project/issues?id=f2calv_SmartHaus&issues=AaFueqewY4cSrRUGMk6G&open=AaFueqewY4cSrRUGMk6G&pullRequest=129

Check warning on line 49 in src/CasCap.App.Server.Tests/Tests/Unit/MieleClientFailureTests.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor your code not to use hardcoded absolute paths or URIs. 

See more on https://sonarcloud.io/project/issues?id=f2calv_SmartHaus&issues=AaFueqcQY4cSrRUGMk5F&open=AaFueqcQY4cSrRUGMk5F&pullRequest=129

Check warning on line 75 in src/CasCap.App.Server.Tests/Infrastructure/DeviceApiWebApplicationFactory.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make 'GetSnapshot' a static method. 

See more on https://sonarcloud.io/project/issues?id=f2calv_SmartHaus&issues=AaFueqcaY4cSrRUGMk5U&open=AaFueqcaY4cSrRUGMk5U&pullRequest=129

Check warning on line 130 in src/CasCap.App.Server.Tests/Tests/Unit/BuderusQueryServiceTests.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make 'GetEvents' a static method. 

See more on https://sonarcloud.io/project/issues?id=f2calv_SmartHaus&issues=AaFueqcVY4cSrRUGMk5O&open=AaFueqcVY4cSrRUGMk5O&pullRequest=129

Check warning on line 133 in src/CasCap.App.Server.Tests/Infrastructure/DeviceApiWebApplicationFactory.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused method parameter 'bulbIdentifier'. 

See more on https://sonarcloud.io/project/issues?id=f2calv_SmartHaus&issues=AaFueqcaY4cSrRUGMk51&open=AaFueqcaY4cSrRUGMk51&pullRequest=129

Check warning on line 26 in src/CasCap.App.Server.Tests/Tests/Integration/MieleMcpContractTests.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this null-forgiving operator; nullable warnings are disabled here. 

See more on https://sonarcloud.io/project/issues?id=f2calv_SmartHaus&issues=AaFueqcJY4cSrRUGMk46&open=AaFueqcJY4cSrRUGMk46&pullRequest=129

Check warning on line 100 in src/CasCap.App.Server.Tests/Infrastructure/DeviceApiWebApplicationFactory.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make 'GetLatestSnapshots' a static method. 

See more on https://sonarcloud.io/project/issues?id=f2calv_SmartHaus&issues=AaFueqcaY4cSrRUGMk5e&open=AaFueqcaY4cSrRUGMk5e&pullRequest=129

Check warning on line 126 in src/CasCap.App.Server.Tests/Infrastructure/DeviceApiWebApplicationFactory.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused method parameter 'bulbIdentifier'. 

See more on https://sonarcloud.io/project/issues?id=f2calv_SmartHaus&issues=AaFueqcaY4cSrRUGMk5x&open=AaFueqcaY4cSrRUGMk5x&pullRequest=129

Check warning on line 286 in src/CasCap.Api.Knx/Services/KnxMonitorService.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this null-forgiving operator; nullable warnings are disabled here. 

See more on https://sonarcloud.io/project/issues?id=f2calv_SmartHaus&issues=AaFueqZ3Y4cSrRUGMk42&open=AaFueqZ3Y4cSrRUGMk42&pullRequest=129

Check warning on line 72 in src/CasCap.App.Server.Tests/Tests/Integration/MieleMcpContractTests.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of using this literal 'example' 9 times. 

See more on https://sonarcloud.io/project/issues?id=f2calv_SmartHaus&issues=AaFueqcJY4cSrRUGMk45&open=AaFueqcJY4cSrRUGMk45&pullRequest=129

Check warning on line 73 in src/CasCap.App.Server.Tests/Infrastructure/DeviceApiWebApplicationFactory.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused method parameter 'limit'. 

See more on https://sonarcloud.io/project/issues?id=f2calv_SmartHaus&issues=AaFueqcaY4cSrRUGMk5b&open=AaFueqcaY4cSrRUGMk5b&pullRequest=129

Check warning on line 134 in src/CasCap.App.Server.Tests/Infrastructure/DeviceApiWebApplicationFactory.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused method parameter 'cancellationToken'. 

See more on https://sonarcloud.io/project/issues?id=f2calv_SmartHaus&issues=AaFueqcaY4cSrRUGMk54&open=AaFueqcaY4cSrRUGMk54&pullRequest=129

Check warning on line 132 in src/CasCap.App.Server.Tests/Infrastructure/DeviceApiWebApplicationFactory.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make 'DiscoverBulbs' a static method. 

See more on https://sonarcloud.io/project/issues?id=f2calv_SmartHaus&issues=AaFueqcaY4cSrRUGMk5t&open=AaFueqcaY4cSrRUGMk5t&pullRequest=129

Check warning on line 91 in src/CasCap.App.Server.Tests/Infrastructure/DeviceApiWebApplicationFactory.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make 'GetActiveDeviceInfo' a static method. 

See more on https://sonarcloud.io/project/issues?id=f2calv_SmartHaus&issues=AaFueqcaY4cSrRUGMk5Y&open=AaFueqcaY4cSrRUGMk5Y&pullRequest=129

Check warning on line 29 in src/CasCap.App.Server.Tests/Tests/Unit/DDnsLeadershipTests.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this null-forgiving operator; nullable warnings are disabled here. 

See more on https://sonarcloud.io/project/issues?id=f2calv_SmartHaus&issues=AaFueqcSY4cSrRUGMk5H&open=AaFueqcSY4cSrRUGMk5H&pullRequest=129

Check warning on line 109 in src/CasCap.Api.Knx/Services/RedisKnxTelegramBroker{T}.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this 'TODO' comment. 

See more on https://sonarcloud.io/project/issues?id=f2calv_SmartHaus&issues=AaFueqTWY4cSrRUGMk4v&open=AaFueqTWY4cSrRUGMk4v&pullRequest=129

Check warning on line 55 in src/CasCap.Api.DDns/Services/DDnsUpdateService.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Loop should be simplified by calling Select(aRecord => aRecord.Data) 

See more on https://sonarcloud.io/project/issues?id=f2calv_SmartHaus&issues=AaFueqcmY4cSrRUGMk6E&open=AaFueqcmY4cSrRUGMk6E&pullRequest=129

Check warning on line 107 in src/CasCap.App.Server.Tests/Infrastructure/DeviceApiWebApplicationFactory.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make 'GetSnapshot' a static method. 

See more on https://sonarcloud.io/project/issues?id=f2calv_SmartHaus&issues=AaFueqcaY4cSrRUGMk5h&open=AaFueqcaY4cSrRUGMk5h&pullRequest=129

Check warning on line 134 in src/CasCap.App.Server.Tests/Infrastructure/DeviceApiWebApplicationFactory.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make 'GetSystemConfig' a static method. 

See more on https://sonarcloud.io/project/issues?id=f2calv_SmartHaus&issues=AaFueqcaY4cSrRUGMk5w&open=AaFueqcaY4cSrRUGMk5w&pullRequest=129

Check warning on line 87 in src/CasCap.App.Server.Tests/Infrastructure/DeviceApiWebApplicationFactory.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make 'GetInverterSnapshot' a static method. 

See more on https://sonarcloud.io/project/issues?id=f2calv_SmartHaus&issues=AaFueqcaY4cSrRUGMk5Z&open=AaFueqcaY4cSrRUGMk5Z&pullRequest=129

Check warning on line 59 in src/CasCap.App.Server.Tests/Tests/Unit/DDnsLeadershipTests.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor your code not to use hardcoded absolute paths or URIs. 

See more on https://sonarcloud.io/project/issues?id=f2calv_SmartHaus&issues=AaFueqcSY4cSrRUGMk5K&open=AaFueqcSY4cSrRUGMk5K&pullRequest=129
View more details on SonarQubeCloud