Conversation
limdor
force-pushed
the
extra_known_features
branch
from
August 10, 2026 16:25
8896d2d to
3cb1a0a
Compare
limdor
force-pushed
the
extra_known_features
branch
2 times, most recently
from
August 11, 2026 12:50
8cfbe2c to
ba4ed80
Compare
limdor
marked this pull request as ready for review
August 11, 2026 12:51
Author
|
@f0rmiga if you could trigger the tests it would be great. I tried locally |
This enables the option to provide rules-based features into the toolchains_llvm. This can be used to inject custom features or to have an easier transition to rules-based toolchains. Fixes f0rmiga#219
To be able to inject cc_feature, at least rules_cc 0.2.17 is needed. 0.2.17 was already the version specified in MODULE.bazel but not in the dependency comming from WORKSPACE file.
limdor
force-pushed
the
extra_known_features
branch
from
August 12, 2026 09:22
ba4ed80 to
da13ad2
Compare
Author
|
@f0rmiga do you think you could at least trigger the tests? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables the option to provide rules-based features into the toolchains_llvm. This can be used to inject custom features or to have an easier transition to rules-based toolchains.
Fixes #219