fix: support :has() and :only-child and modern pseudo-classes in ExtractStyleBlocks - #488
Open
ezyang wants to merge 2 commits into
Open
fix: support :has() and :only-child and modern pseudo-classes in ExtractStyleBlocks#488ezyang wants to merge 2 commits into
ezyang wants to merge 2 commits into
Conversation
…actStyleBlocks - Expand _enum_attrdef whitelist to include has, only-child and 30+ modern pseudo-classes/elements (from issue #397 comment) - Handle functional pseudo-classes (has(), not(), nth-child() etc.) with parentheses - validate function name and keep whole value - Protect : inside functional pseudo parentheses so :has(br:only-child) is not split into has(br + only-child) Fixes #397 - p:has(br:only-child) was stripped to p
Rename inner loop var $k => $ck to prevent overwriting outer foreach key.
Fixes 20 ExtractStyleBlocksTest failures where numeric key 0/2/4
leaked as '0 { ... }'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #397
Before: p:has(br:only-child) { margin:0 } -> p { margin:0 } (stripped)
After: preserved as p:has(br:only-child)
Closes #397