Repository navigation
fix(web): show real member and public URLs in workspace and board settings - #93
Merged
Merged
Conversation
…tings El hint "Used in URLs" hardcodeaba un dominio inexistente (echolog.app) y asumía routing por slug que no existe: las rutas de miembros usan el id (/w/:workspaceId, /w/:workspaceId/b/:boardId) y el slug solo alimenta el discovery público (/explore/:slug). Ahora se deriva el dominio real de window.location.origin y se muestran ambas URLs, aclarando que el slug solo afecta la página pública y que cambiarlo rompe links compartidos.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
echolog.app) and assumed slug-based routing that doesn't exist: member routes use IDs (/w/:workspaceId,/w/:workspaceId/b/:boardId), and the slug only feeds public discovery (/explore/:slug).window.location.origin(works in local, Vercel, or Render) and show the honest Member URL (ID-based) and Public URL (/explore/...).main; the old local working tree contained only Prettier formatting noise, preserved in a local stash.Changes
web/src/workspaces/components/workspace-settings-page.tsxecholog.app/w/{slug}with real Member/Public URLs fromwindow.location.origin+ slug warningweb/src/boards/components/board-settings-page.tsx/w/acme/feature-requestsexample with real Member/Public URLs; added workspace lookup from cache to show the public board URLTest Plan
tsc --noEmit)