Skip to content

NOTASK: Use 52008 as the method option number #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
far4599 merged 1 commit into from
Oct 19, 2026
Merged

NOTASK: Use 52008 as the method option number #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,4 @@ buf generate
go test ./...
```

The extension number `52000` and the field numbers of `MethodAuth` never change.
The extension number `52008` and the field numbers of `MethodAuth` never change.
8 changes: 4 additions & 4 deletions exframe/auth/v1/auth.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion exframe/auth/v1/auth.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ message MethodAuth {

extend google.protobuf.MethodOptions {
// A method without the option is closed for every caller.
MethodAuth method = 52000;
MethodAuth method = 52008;
}
4 changes: 2 additions & 2 deletions exframe/auth/v1/auth_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ func TestExtension(t *testing.T) {
t.Parallel()

ext := E_Method.TypeDescriptor()
if got := ext.Number(); got != 52000 {
t.Fatalf("extension number = %d, want 52000", got)
if got := ext.Number(); got != 52008 {
t.Fatalf("extension number = %d, want 52008", got)
}
if got := ext.FullName(); got != "exframe.auth.v1.method" {
t.Fatalf("extension name = %q, want exframe.auth.v1.method", got)
Expand Down
Loading