Repository navigation
test(channels): wait for the sendVoice reply in the voice note test - #549
PruthviRajSolase wants to merge 1 commit into
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Wait for the voice reply tests/channels/test_telegram.py |
The test waits for a recorded sendVoice call before it checks the voice payload and confirms that no sendAudio call occurred. |
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Other · Severity of issue fixed: Low
Suggested labels: area: channels
Suggested reviewers: itsskofficial, kabeer2004
Merge Risk: 
Minimal · up to b7819
-
The test now waits for the voice reply without weakening its payload checks. No actionable merge-blocking risk was identified.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passed-
Full details: Title check
-
Explanation
The title names the change correctly. The PR makes the voice-note test wait for a sendVoice call before it asserts, and the title says the same. It uses the conventional test(channels) prefix and stays specific to the sendVoice reply in the voice note test.
Full details: Linked Issues check
-
Explanation
Issue
#546requires a bounded wait for the asynchronoussendVoicecall intests/channels/test_telegram.py::test_voice_note_is_transcribed_and_answered. The PR adds the existinguntilhelper with a 30-second bound before thesendVoiceassertions. The reported channel tests, lint checks, and repeated test runs support the change.
Full details: Out of Scope Changes check
-
Explanation
The PR changes only the timing of the
sendVoiceassertion in the test named by issue#546. The payload andsendAudioassertions remain unchanged. No unrelated behavior or production code changes are reported.
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches
-
Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit waits while voice calls land
Then checks the payload, neat and grand
No audio call slips past the test
The voice reply gets checked with care
And floppy ears applaud the fix
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
Closes #546
The spoken reply (
voice_replies = True) is sent after the text reply, but the test asserted onsendVoiceright aftertg.say(...)returned. Under load the call hadn't landed yet, solen(voices) == 1failed.The test now waits for the
sendVoicecall with the existinguntilhelper (bounded at 30 s) before asserting. No behaviour change; the assertions that follow are unchanged.Checked:
pytest tests/channelspasses (163 passed, 1 skipped)ruff check sentient testspassesSummary by CodeRabbit