Repository navigation
Add support for ruby 4 and fix the publishing workflow - #3
Merged
Merged
Conversation
Nkemjiks
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Ruby 4.0 support and fixes the publishing workflow, which has never been able to run since it was added.
Ruby 4 support
memorb.gemspec: removed the< 3.5upper bound onrequired_ruby_version.memorb.gemspec: relaxed thebundlerdevelopment dependency from~> 2.0to>= 2.0. Ruby 4.0 ships Bundler 4.0.3, and without this changebundle installfails on Ruby 4:lib/memorb/version.rb: bumped1.0.0to1.1.0. Adding a supported Ruby is additive, so a minor bump.CHANGELOG.md: added the1.1.0entry..github/workflows/main.yml: addedruby-4.0(Bundler4.0) to the test matrix.No changes to
lib/were needed. Nothing in the library gates onRUBY_VERSION, andconcurrent-ruby ~> 1.1resolves cleanly on Ruby 4.Workflow fixes
Publishing was dead code. Both the
pushtrigger and the publish job'sif:guard referencedmaster, but the default branch ismain. Pushes tomainnever triggered the workflow, so the1.0.0release never published to GitHub Packages. Both references now point atmain.Actions pinned to commit SHAs as a supply-chain precaution, with the version in a trailing comment so Dependabot can still track them:
actions/checkout@v4@3d3c42e5aac5ba805825da76410c181273ba90b1(v7.0.1)ruby/setup-ruby@v1@95ef2b042f9d7a56d8268cba8559e2842e2ad01b(v1.321.0)The
checkoutjump from v4 to v7 requires a Node 24 capable runner (v5) and moves persisted credentials to a separate file (v6). Neither affects this workflow: it runs on GitHub-hostedubuntu-latestand nothing depends on the credential location.Misc
.gitignore: added.serena/(local tooling state).Verification
Ran locally against both Rubies with a fresh
Gemfile.lock:bundle installbundle exec rspecgem buildmemorb-1.1.0.gemWorkflow file parses as valid YAML and passes
actionlint(only pre-existing shellcheck style notes on the*.gemspec/*.gemglobs).Heads up for merging
This is the first time the publish job will actually fire. Merging to
mainwill pushmemorb 1.1.0to GitHub Packages.