🐛 server: fix forwarded card webhook status - #1186
Conversation
🦋 Changeset detectedLatest commit: 00b068e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughCard webhook forwarding and validation now use ChangesCard webhook status alignment
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 4fab94aa-fc90-4eea-9138-459c7f98473a
📒 Files selected for processing (4)
.changeset/brave-otters-listen.mddocs/src/content/docs/webhooks.mdserver/hooks/panda.tsserver/test/hooks/panda.test.ts
| | body.limit.amount | number | spending limit amount | 1000000 | | ||
| | body.limit.frequency | "per24HourPeriod" \| "per7DayPeriod" \| "per30DayPeriod" \| "perYearPeriod" | frequency of the spending limit | per7DayPeriod | | ||
| | body.status | "ACTIVE" \| "FROZEN" \| "DELETED" \| "INACTIVE" | current status of the card | ACTIVE | | ||
| | body.status | "ACTIVE" \| "LOCKED" \| "DELETED" \| "INACTIVE" | current status of the card | ACTIVE | |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Document the trigger for LOCKED card updates.
The enum now includes LOCKED, and the forwarding tests cover locked-card updates, but the description at Line 644 still says this webhook is triggered only when a card is added to a digital wallet. Update it to describe when locked-card events can arrive.
Summary by CodeRabbit
Bug Fixes
LOCKED.Documentation
LOCKEDinstead ofFROZEN.Tests