Skip to content

Add Galaxy workflow metadata defaults - #6

Merged
poautran merged 2 commits into
mainfrom
fix-gxformat2-lint-metadata
Mar 31, 2026
Merged

poautran merged 2 commits into
mainfrom
fix-gxformat2-lint-metadata

Conversation

@poautran

@poautran poautran commented Mar 30, 2026 •

Copy link
Copy Markdown
Member

CI failed when I switch readthedocs to run on ub24.04. This is an attempt to fix it.

Seems like those missing metadata are raising warnings since the release of gxformat2

@codecov

codecov Bot commented Mar 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@poautran
poautran requested a review from loichuder March 31, 2026 07:32
@loichuder

Copy link
Copy Markdown
Member

Wait, I don't get it.

Why is the CI failing now? There was no gxformat2 release since it passed for the last time. 🤔

@poautran

Copy link
Copy Markdown
Member Author

I think the last run was on March 9th, actually there were 2 releases since, but it it not because of the release themselves that CI broke.
It is likely because of: galaxyproject/gxformat2@e9b1447

Which is not released yet, but our pyproject.toml has:

dependencies = [
    "ewokscore",
    "gxformat2@ git+https://github.com/galaxyproject/gxformat2", # To have https://github.com/galaxyproject/gxformat2/pull/134
]

Since PR 134 is merged and released in 0.23.0, switching back the gxformat2 to >=0.23.0 would restore the CI, until a new version is released.

@loichuder

Copy link
Copy Markdown
Member

I see, thanks!

Can I abuse of your kindness and ask to change to dependency to >= 0.23.0 ? 😊

@poautran

Copy link
Copy Markdown
Member Author

Will close this PR and keep to for future reference in case we need it.

@poautran poautran closed this Mar 31, 2026
@loichuder

Copy link
Copy Markdown
Member

Will close this PR and keep to for future reference in case we need it.

No, you can change the dep in this PR. The changes make sense if it will break at some point.

@poautran poautran reopened this Mar 31, 2026
@poautran
poautran force-pushed the fix-gxformat2-lint-metadata branch from 8c05ce9 to cb56334 Compare March 31, 2026 09:40
@poautran

Copy link
Copy Markdown
Member Author

Ok! Done here: #7 and rebased

@loichuder loichuder left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@poautran
poautran merged commit f09b302 into main Mar 31, 2026
8 checks passed
@poautran
poautran deleted the fix-gxformat2-lint-metadata branch March 31, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants